#4295 Keep master, slaves, keepReplica params in MasterSlaveConnection #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralos
changed the title
kralos
force-pushed
the
4295-connection-params-bc-break
branch
3 times, most recently
from
8d7c18a
to
f0b9b39
Compare
|
@greg0ire CI failure is unrelated to this MR, can you force it to retry or override? |
stof
reviewed
Sep 28, 2020
tests/Doctrine/Tests/DBAL/Connections/MasterSlaveConnectionTest.php
Outdated
Show resolved
Hide resolved
kralos
force-pushed
the
4295-connection-params-bc-break
branch
from
f0b9b39
to
acf3530
Compare
greg0ire
reviewed
Sep 28, 2020
tests/Doctrine/Tests/DBAL/Connections/MasterSlaveConnectionTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Tests/DBAL/Connections/MasterSlaveConnectionTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Tests/DBAL/Connections/MasterSlaveConnectionTest.php
Outdated
Show resolved
Hide resolved
kralos
force-pushed
the
4295-connection-params-bc-break
branch
from
acf3530
to
066049d
Compare
kralos
force-pushed
the
4295-connection-params-bc-break
branch
from
066049d
to
c50a58e
Compare
greg0ire
reviewed
Sep 28, 2020
greg0ire
approved these changes
Sep 28, 2020
morozov
approved these changes
Sep 30, 2020
rgrellmann
added a commit
to Rossmann-IT/dbal
that referenced
this pull request
Mar 7, 2021
Release [2.11.2](https://github.com/doctrine/dbal/milestone/81) 2.11.2 ====== - Total issues resolved: **5** - Total pull requests resolved: **16** - Total contributors: **10** Static Analysis --------------- - [4353: Update Psalm to 3.17.2 and lock the version used with GitHub Actions](doctrine#4353) thanks to @morozov - [4348: Bump Psalm level to 3](doctrine#4348) thanks to @morozov - [4332: Static analysis improvements](doctrine#4332) thanks to @morozov - [4319: Bump Psalm level to 4](doctrine#4319) thanks to @morozov Code Style ---------- - [4346: Minor CS improvement - use ::class for TestCase::expectException input](doctrine#4346) thanks to @mvorisek - [4344: Static analysis workflow](doctrine#4344) thanks to @greg0ire - [4340: Modernize existing ga](doctrine#4340) thanks to @greg0ire - [4309: Use cache action v2](doctrine#4309) thanks to @greg0ire - [4305: Move website config to default branch](doctrine#4305) thanks to @SenseException Improvement,Prepared Statements ------------------------------- - [4341: Add Statement::fetchAllIndexedAssociative() and ::iterateIndexedAssociative()](doctrine#4341) thanks to @morozov and @ZaneCEO - [4338: Add Statement::fetchAllKeyValue() and ::iterateKeyValue()](doctrine#4338) thanks to @morozov BC Fix,Query ------------ - [4330: Fix regression in QueryBuilder::and|orWhere()](doctrine#4330) thanks to @BenMorel Test Suite ---------- - [4321: Update PHPUnit to 9.4](doctrine#4321) thanks to @morozov Columns,SQL Server,Schema Managers ---------------------------------- - [4315: Fix handling existing SQL Server column comment when other properties change](doctrine#4315) thanks to @trusek CI -- - [4310: Migrate jobs away from Travis to Github Actions ](doctrine#4310) thanks to @greg0ire BC Fix,Connections ------------------ - [4308: doctrine#4295 Keep master, slaves, keepReplica params in MasterSlaveConnection](doctrine#4308) thanks to @kralos New Feature,Prepared Statements ------------------------------- - [4289: Add a fetch mode methods for "PDO::FETCH&doctrine#95;KEY&doctrine#95;PAIR"](doctrine#4289) thanks to @tswcode Bug,SQL Server,Schema --------------------- - [3400: Wrong column comment setting command in migrations of SQL Server](doctrine#3400) thanks to @msyfurukawa # gpg: Signature made Mon Oct 19 04:18:17 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure
Doctrine\DBAL\Connections\MasterSlaveConnection$paramsare not stripped asDoctrine\DBAL\Connection::getParamsis public and used by other libraries (e.g.doctrine/doctrine-bundle).