Allow Symfony 6 #4656
Merged
Allow Symfony 6 #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
suggested changes
May 19, 2021
| "symfony/cache": "^5.2", | ||
| "symfony/console": "^2.0.5|^3.0|^4.0|^5.0", | ||
| "symfony/cache": "^5.2|^6.0", | ||
| "symfony/console": "^2.0.5|^3.0|^4.0|^5.0|^6.0", |
There was a problem hiding this comment.
Suggested change
| "symfony/console": "^2.0.5|^3.0|^4.0|^5.0|^6.0", | |
| "symfony/console": "^3.4|^4.4|^5.2|^6.0", |
There is no point to support the not maintained versions IMHO.
There was a problem hiding this comment.
I don't have opinion about this, but this is not the purpose of this PR, and think that should be discussed in a dedicated PR.
greg0ire
approved these changes
May 19, 2021
This comment has been minimized.
This comment has been minimized.
|
Thanks @jderusse ! |
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as #3563
Still not strictly required as it doesn't block the Symfony 6 CI. Yet will help ensure Symfony 6 is compatible
Yes @greg0ire one more pipe