Unit Test for getTableWhereClause method #493
Conversation
Unit Test for the commit doctrine#492 [Fix statement for getTableWhereClause method]( doctrine#492)
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-763 We use Jira to track the state of pull requests and the versions they got |
| SELECT indexrelid | ||
| FROM pg_index si, pg_class sc, pg_namespace sn | ||
| WHERE sc.relname = 'state' AND sn.nspname = ANY(string_to_array((select replace(replace(setting,'\"\$user\"',user),' ','') from pg_catalog.pg_settings where name = 'search_path'),',')) AND sc.oid=si.indrelid AND sc.relnamespace = sn.oid | ||
| ) AND pg_index.indexrelid = oid", $this->_patform->getListTableForeignKeysSQL($table, $database)); |
There was a problem hiding this comment.
It's $this->_platform. You are using it wrong everywhere.
|
I don't think this is the right approach as we tend rather not to unittest the |
|
@deeky666 Sorry about that... I don't know how to make a unit test here and I don't know what is or not a private property... I guided by AbstractPostgreSqlPlatformTestCase.php and on this file access to I did this only because you requested me to, but I told you earlier that I can't make a test on PHP when the change is on a SQL query. But however, somebody should make a real test for PostgreSQL platform not with a simple table named |
Unit Test for the commit #492 Fix statement for getTableWhereClause method