Accept strings in AbstractPlatform::get*Expression() methods #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
get-expression-string
branch
from
56d5e3a to
e9834b7
Compare
morozov
force-pushed
the
get-expression-string
branch
from
e9834b7 to
ee571fb
Compare
derrabus
approved these changes
Dec 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
AbstractPlatform::get*Expression()methods that build SQL by concatenating their parameters should accept strings. See #3498.Otherwise, passing an SQL expression as the
$startPosargument ofgetLocateExpression()works but is flagged as a type issue. See doctrine/orm#9266.