Fix sqlite autoincrement detection #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-792 We use Jira to track the state of pull requests and the versions they got |
| @@ -493,6 +493,18 @@ public function testAutoincrementDetection() | |||
| $inferredTable = $this->_sm->listTableDetails('test_autoincrement'); | |||
| $this->assertTrue($inferredTable->hasColumn('id')); | |||
| $this->assertTrue($inferredTable->getColumn('id')->getAutoincrement()); | |||
|
|
|||
| $table = new \Doctrine\DBAL\Schema\Table('test_not_autoincrement'); | |||
There was a problem hiding this comment.
Create a new test method instead (with @group DBAL-792)
beberlei
added a commit
that referenced
this pull request
Feb 8, 2014
Fix sqlite autoincrement detection
bartv2
added a commit
to owncloud-archive/3rdparty
that referenced
this pull request
Feb 18, 2014
|
@beberlei Can this be backported to 2.4? THX |
|
@bantu Only @beberlei and @guilhermeblanco merge PRs. They will have a look at the PRs to be merged soon :) |
|
in this case to be backported of course. |
|
@beberlei Can we get this backported to 2.3 please? |
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are 2 PK-columns the code would still mark the first column as autoincrement.