Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use closures in portability converter #5936

Merged

Conversation

derrabus
Copy link
Member

Q A
Type improvement
Fixed issues N/A

Summary

With first class callable syntax in PHP 8.1, I think we can improve the code of the portability middleware's Converter class by turning all callables into actual closures. This also allows us to use typed properties in that file.

@derrabus derrabus merged commit 0e8256e into doctrine:4.0.x Feb 28, 2023
@derrabus derrabus deleted the improvement/typed-portability-converter branch February 28, 2023 07:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants