Trigger runtime deprecations for legacy API #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
deprecate/fetch-mode
branch
from
aa5449e
to
426538f
Compare
morozov
previously approved these changes
Mar 2, 2023
derrabus
force-pushed
the
deprecate/fetch-mode
branch
from
426538f
to
3c246b4
Compare
morozov
previously approved these changes
Mar 2, 2023
greg0ire
reviewed
Mar 4, 2023
derrabus
force-pushed
the
deprecate/fetch-mode
branch
from
3c246b4
to
fff363d
Compare
greg0ire
approved these changes
Mar 5, 2023
This was referenced Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd like to remove the legacy API in 4.0. We intended to remove it "after 2022" which kinda is now. Besides that, we're going to maintain 3.x for quite a while and the upgrade path for each of the deprecated methods should be pretty easy.