Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants for DBAL types at DB2Platform::initializeDoctrineTypeMappings() #5995

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Use constants for DBAL types at DB2Platform::initializeDoctrineTypeMappings() #5995

merged 1 commit into from
Apr 9, 2023

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 8, 2023

Q A
Type improvement
Fixed issues n/a

Summary

Use constants from Doctrine\DBAL\Types\Types instead of hardcoded values.

@phansys phansys marked this pull request as ready for review April 8, 2023 12:48
@derrabus derrabus added this to the 3.7.0 milestone Apr 8, 2023
@derrabus derrabus changed the base branch from 3.6.x to 3.7.x April 9, 2023 22:52
@derrabus derrabus merged commit 36850b6 into doctrine:3.7.x Apr 9, 2023
@derrabus
Copy link
Member

derrabus commented Apr 9, 2023

Makes sense, thank you.

@phansys phansys deleted the db2_types branch April 9, 2023 23:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
IBM DB2 Improvement Platforms Type Mapping
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phansys @derrabus