-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow DsnParser
to parse driverClass
via $schemeMapping
#6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
dsn-parser-driver-class
branch
from
June 7, 2023 18:59
90bb80c
to
6d67518
Compare
Makes perfect sense to me. Can you please also update the documentation on the DSN parser? dbal/docs/en/reference/configuration.rst Lines 100 to 135 in 4e673be
|
kbond
force-pushed
the
dsn-parser-driver-class
branch
from
June 8, 2023 13:31
6d67518
to
6250dff
Compare
Docs added. |
derrabus
approved these changes
Jun 8, 2023
derrabus
changed the title
feat: allow
Allow Jun 8, 2023
DsnParser
to parse driverClass
via $schemeMapping
DsnParser
to parse driverClass
via $schemeMapping
Awesome, thank you! |
thank you for this feature, this is much appreciated when using a custom driver with doctrine-bundle, while still needing to use a url to configure the database connection |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The latest version of dbal & doctrine-bundle remove the ability to use a dsn (url param) to configure a custom
driverClass
.This is a proposal to allow
DsnParser::$schemeMapping
to map an alias to adriverClass
. With doctrine-bundle, these custom drivers could be added to thedoctrine.dbal.driver_schemes
config:If this feature isn't desired, any other ideas?