Fix blob binding overwrite on DB2 #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Jul 14, 2023
melekhovets
force-pushed
the
fix-db2-blob-binding-overwrite
branch
from
5028c59
to
af8bef2
Compare
On DB2 when binding more than 1 blob in the same statement each subsequent blob overwrites previous one. So instead of [1, 2, 3] we get [2, 3, 3] This happens because of reference between loop variable `$value` and the item in `$this->parameters[]`, which remains after iteration, see `bindLobs` and `bind` methods in `\Doctrine\DBAL\Driver\IBMDB2\Statement`
melekhovets
force-pushed
the
fix-db2-blob-binding-overwrite
branch
from
af8bef2
to
8eee35b
Compare
morozov
approved these changes
Jul 17, 2023
derrabus
approved these changes
Jul 17, 2023
|
Thank you! |
derrabus
added a commit
that referenced
this pull request
Jul 23, 2023
* 3.6.x: Fix blob binding overwrite on DB2 (#6093)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 24, 2023
* 3.7.x: Avoid self deprecation about listTableColumn (doctrine#6108) Fix blob binding overwrite on DB2 (doctrine#6093) Optimize TypeRegistry::lookupName() from O(N) to O(1) (doctrine#6082) Add documentation for doctrine#6044 (doctrine#6069) Use triggerIfCalledFromOutside in listTableDetails Document alternative to Type::getName (doctrine#6077)
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On DB2 when binding more than 1 blob in the same statement each subsequent blob overwrites previous one. So instead of [1, 2, 3] we get [2, 3, 3]
This happens because of reference between the loop variable
$valueand the item in$this->parameters[], which remains after iteration, seebindLobsandbindmethods in\Doctrine\DBAL\Driver\IBMDB2\Statement