Restore reverse lookup determinism #6097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 96c2ebf, it looks like I wrongly assumed I wouldn't be able to allow having 2 classes of the same type in the type registry without also allowing having 2 objects of the same type. array_search can perfectly tell the difference between both situations, so let us continue forbidding that last part, it will allow us to make sure a given type matches exactly one name.
derrabus
previously approved these changes
Jul 15, 2023
greg0ire
force-pushed
the
restore-lookup-determinism
branch
from
94703ef
to
ba63843
Compare
|
@derrabus sorry, I forgot to implement override. Now that I look at it, this effectively reverts all the code introduced in #5036 🤔 |
derrabus
approved these changes
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5036, it looks like I wrongly assumed I wouldn't be able to allow having 2 classes of the same type in the type registry without also allowing having 2 objects of the same type.
array_searchcan perfectly tell the difference between both situations, so let us continue forbidding that last part, it will allow us to make sure a given type matches exactly one name.