PHPStan 1.10.26 #6116
Merged
PHPStan 1.10.26 #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jul 27, 2023
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Aug 8, 2023
* 3.6.x: Run tests with MySQL 8.1 (doctrine#6118) Fix a typo and a space (doctrine#6119) PHPStan 1.10.26 (doctrine#6116) Fix self deprecation
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Aug 8, 2023
* 3.7.x: Run tests with MySQL 8.1 (doctrine#6118) Sync MariaDB support strategy with upstream (doctrine#6110) Fix a typo and a space (doctrine#6119) PHPStan 1.10.26 (doctrine#6116) Fix self deprecation Pin Slevomat Coding Standard
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | N/A #### Summary Apparently, the stubs for `db2_num_rows()` were changed upstream. I'm ignoring the error for now, maybe we can fix it on 3.7.x if we feel like it's worth doing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apparently, the stubs for
db2_num_rows()were changed upstream. I'm ignoring the error for now, maybe we can fix it on 3.7.x if we feel like it's worth doing.