Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Leverage built-in healthcheck for "db2" service #6159

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Sep 20, 2023

Q A
Type improvement
Fixed issues n/a

Follows #5958.

Summary

This change is consistent with what other services defined in this pipeline do.

@derrabus
Copy link
Member

It works, apparently. Is there anything left to do to not mark it as draft?

@phansys
Copy link
Contributor Author

phansys commented Sep 24, 2023

It works, apparently. Is there anything left to do to not mark it as draft?

It seems to work, but I'd like to confirm it is not just the result of a race condition.
I'll be re-launching the jobs few times in order to confirm.

@derrabus
Copy link
Member

Just tell me when you feel ready. Also, if we see that the health check does not work as we expected, we can always revert the PR.

@phansys phansys marked this pull request as ready for review September 26, 2023 21:44
@derrabus derrabus added this to the 3.7.1 milestone Sep 26, 2023
@derrabus derrabus merged commit 56e75cf into doctrine:3.7.x Sep 26, 2023
80 checks passed
@phansys phansys deleted the ci_db2_healthcheck branch September 26, 2023 22:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants