Add Oracle v23 to CI testing #6217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Nov 6, 2023
| @@ -148,7 +149,7 @@ jobs: | |||
| composer-options: "--ignore-platform-req=php+" | |||
|
|
|||
| - name: "Run PHPUnit" | |||
| run: "vendor/bin/phpunit -c ci/github/phpunit/oci8.xml --coverage-clover=coverage.xml" | |||
| run: "vendor/bin/phpunit -c ci/github/phpunit/oci8${{ matrix.oracle-version < 23 && '-21' || '' }}.xml --coverage-clover=coverage.xml" | |||
There was a problem hiding this comment.
needed because different dbname is needed - gvenzl/oci-oracle-xe#238
|
Awesome, thank you! |
derrabus
approved these changes
Nov 6, 2023
derrabus
added a commit
that referenced
this pull request
Nov 6, 2023
* 3.7.x: Add Oracle v23 to CI testing (#6217)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 11, 2023
* 3.8.x: Enable skipping locked rows in QueryBuilder Fix coding standard violation Remove unused unit test fixtures Add Oracle v23 to CI testing (doctrine#6217) Extend `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` deprecation layer (doctrine#6215) Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (doctrine#6213) Fix MariaDB list columns performance (doctrine#6202)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Nov 11, 2023
* 3.8.x: Enable skipping locked rows in QueryBuilder Fix coding standard violation Remove unused unit test fixtures Add Oracle v23 to CI testing (doctrine#6217) Extend `AbstractMySQLPlatform::getColumnTypeSQLSnippets()` deprecation layer (doctrine#6215) Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (doctrine#6213) Fix MariaDB list columns performance (doctrine#6202)
allan-simon
pushed a commit
to allan-simon/dbal
that referenced
this pull request
Nov 13, 2023
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | n/a #### Summary Latest Oracle database compatibility should be tested. Targetting lowest open branch to assert the compatibility for 3.7.x too for possible bugfixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Latest Oracle database compatibility should be tested.
Targetting lowest open branch to assert the compatibility for 3.7.x too for possible bugfixes.