Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate MariaDB 10.4 and MySQL 5.7 support #6343

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Mar 21, 2024

Q A
Type improvement
Fixed issues N/A

Summary

Let's not carry support for the following old releases over into the next major.

@derrabus derrabus added this to the 4.1.0 milestone Mar 21, 2024
@derrabus derrabus requested review from morozov and greg0ire March 21, 2024 12:14
@derrabus derrabus force-pushed the deprecate/mariadb-10.4 branch 2 times, most recently from c308049 to 6d383ca Compare March 21, 2024 12:24
@derrabus derrabus force-pushed the deprecate/mariadb-10.4 branch from 6d383ca to e54a666 Compare March 21, 2024 12:28
@derrabus derrabus changed the title Deprecate MariaDB 10.4 support Deprecate MariaDB 10.4 and MySQL 5.7 support Mar 21, 2024
@derrabus derrabus added the MySQL label Mar 21, 2024
@derrabus derrabus merged commit 90e098c into doctrine:4.1.x Mar 21, 2024
75 checks passed
@derrabus derrabus deleted the deprecate/mariadb-10.4 branch March 21, 2024 20:30
derrabus added a commit that referenced this pull request Mar 21, 2024
|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues | Follows #6343

#### Summary

This PR removes support for old MariaDB and MySQL releases.
@alexislefebvre
Copy link

I had a deprecation message with a link to this PR with this config in phpunit.xml.dist:

<env name="DATABASE_URL" value="mysql://root:@mysql:3306/truebadges?serverVersion=8.0" />

Changing 8.0 to 8.0.0 or 8.0.39 removed the message.

This is due to this line:

if (version_compare($version, '8.0.0', '>=')) {
and how PHP compare versions: https://3v4l.org/PLDVi

@derrabus
Copy link
Member Author

derrabus commented Jan 5, 2025

8.0 is not a valid MySQL version while 8.0.39 is.

You can also pass the ``serverVersion`` option if you want to disable automatic
database platform detection and choose the platform version implementation explicitly.
Please specify the full server version as the database server would report it.
This is especially important for MySQL and MariaDB where the full version
string is taken into account when determining the platform.
MySQL
^^^^^
Connect to your MySQL server and run the ``SELECT VERSION()`` query::
mysql> SELECT VERSION();
+-----------+
| VERSION() |
+-----------+
| 8.0.32 |
+-----------+
1 row in set (0.00 sec)
In the example above, ``8.0.32`` is the correct value for ``serverVersion``.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants