[Need Help] Testing boolean comparison using ParameterType #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/boolean-comparison-with-oracle
branch
from
a06ad45 to
acfc0d2
Compare
nickvergessen
changed the title
nickvergessen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Nextcloud we started to experience strange behaviour with Oracle when using boolean
FALSEin WHERE-clauses with parameters.The behaviour works as expected, when as parameter type we pass
Doctrine\DBAL\Types\Types::BOOLEANinstead ofDoctrine\DBAL\ParameterType::BOOLEANin our code base, but I think from the doc blocks and declarations this is not what should be done.This fix can also not be confirmed here using the 4.1.x branch as a base, but my test at least is failing with the same problem/bug: Using
falsein a where condition seems to not be possible?false=> https://github.com/doctrine/dbal/actions/runs/11011058496/job/30574363409?pr=6526#step:6:730=> https://github.com/doctrine/dbal/actions/runs/11011277241/job/30575035189?pr=6526#step:6:73