Leverage the new PDO subclasses #6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
feature/pdo-subclasses
branch
from
6a8f2b1
to
0343ecc
Compare
derrabus
force-pushed
the
feature/pdo-subclasses
branch
2 times, most recently
from
2e8db90
to
c8eecae
Compare
greg0ire
previously approved these changes
Oct 10, 2024
|
I'm working around the PHP bug for the time being. If we try to open a persistent connection, I'm falling back to the old constructor. |
derrabus
force-pushed
the
feature/pdo-subclasses
branch
from
c8eecae
to
3cb79ff
Compare
|
Oh, a new codecov error: codecov/codecov-action#1580 |
greg0ire
approved these changes
Oct 10, 2024
morozov
approved these changes
Oct 10, 2024
GromNaN
approved these changes
Oct 10, 2024
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Oct 10, 2024
* 4.2.x: Implement an EnumType for MySQL/MariaDB (doctrine#6536) Leverage the new PDO subclasses (doctrine#6532) PHPStan 1.12.6 (doctrine#6535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the new PDO subclasses to DBAL.
TODO: