Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover how transactional() behaves in different auto commit modes #6563

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Oct 20, 2024

Q A
Type improvement
Fixed issues

Summary

Covers the concern expressed by @greg0ire #6545 (comment)

This ensures the transaction is (not)active based on autocommmit mode when interacting with transactional().

greg0ire
greg0ire previously approved these changes Oct 20, 2024
tests/ConnectionTest.php Outdated Show resolved Hide resolved
tests/ConnectionTest.php Outdated Show resolved Hide resolved
tests/ConnectionTest.php Outdated Show resolved Hide resolved
tests/ConnectionTest.php Show resolved Hide resolved
@derrabus derrabus added this to the 3.9.4 milestone Oct 31, 2024
@derrabus derrabus merged commit 976f3f3 into doctrine:3.9.x Oct 31, 2024
98 checks passed
@simPod simPod deleted the cover branch October 31, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants