Fixed closing a connection #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inner connection should be unreferenced, but the property should not be removed from the object
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1003 We use Jira to track the state of pull requests and the versions they got |
|
@stof I assume a warning is rised somewhere else if it is unset: is there any API that would cause a notice? |
|
@Ocramius see the linked issue for a case where it can happen |
|
@stof yeah, I was wondering about anything I can use to write a test case. |
malukenho
pushed a commit
to malukenho/dbal
that referenced
this pull request
Oct 16, 2014
malukenho
pushed a commit
to malukenho/dbal
that referenced
this pull request
Oct 16, 2014
Ocramius
added a commit
that referenced
this pull request
Oct 22, 2014
…undefined-_conn-property Close #688
|
@stof merged, thanks! |
Merged
deeky666
pushed a commit
that referenced
this pull request
Nov 5, 2014
sarcher
pushed a commit
to sarcher/dbal
that referenced
this pull request
Jan 1, 2015
This was referenced Dec 6, 2015
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner connection should be unreferenced, but the property should not be removed from the object
Refs #685