Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBAL-1058] Fix database and namespace introspection for SQL Server #736

Merged
merged 1 commit into from
Jan 12, 2015

Conversation

deeky666
Copy link
Member

@deeky666 deeky666 commented Dec 5, 2014

It looks like some SQL Server versions / setups need system tables to be queried lowercased otherwise causing errors.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1060

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius Ocramius self-assigned this Dec 5, 2014
@Ocramius
Copy link
Member

Ocramius commented Dec 5, 2014

Looks sane to me. Did you have a chance to test this on your setup, @deeky666?

@deeky666
Copy link
Member Author

deeky666 commented Dec 5, 2014

@Ocramius yes I tested this and it works. But it worked before for me, too so I have no clue why some people get an error there. Either way, this patch does no harm and system tables are documented lowercase in the SQL Server docs so this should be fine.

@Ocramius
Copy link
Member

Ocramius commented Dec 5, 2014

Waiting for travis and then pressing zeh button

@deeky666
Copy link
Member Author

deeky666 commented Dec 5, 2014

@Ocramius thanks!

@Ocramius
Copy link
Member

Ocramius commented Dec 5, 2014

Also to check: merge back to 2.4

@Ocramius
Copy link
Member

Ocramius commented Dec 6, 2014

New test fails, sadly :-(

@stof
Copy link
Member

stof commented Dec 6, 2014

It should also be backported to 2.5, not only to 2.4

@deeky666
Copy link
Member Author

deeky666 commented Dec 8, 2014

@stof I have that on my list.
@Ocramius will have a look later

@deeky666 deeky666 force-pushed the DBAL-1058 branch 3 times, most recently from 6e9fd13 to 7e435c4 Compare December 28, 2014 00:12
@deeky666
Copy link
Member Author

deeky666 commented Jan 3, 2015

@Ocramius failing tests fixed now :)

@Ocramius
Copy link
Member

Looking good. Will merge today.

Ocramius added a commit that referenced this pull request Jan 12, 2015
…pection-for-sql-server-backport-to-2.5' into 2.5

Close #736
@Ocramius Ocramius merged commit 08f4b2b into doctrine:master Jan 12, 2015
Ocramius added a commit that referenced this pull request Jan 12, 2015
@Ocramius
Copy link
Member

Merged, thanks!

master: 06e64e2
2.5: f6ca269

@Ocramius
Copy link
Member

This won't be backported to 2.4.x due to conflicts - see http://www.doctrine-project.org/jira/browse/DBAL-1061

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants