-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBAL-1058] Fix database and namespace introspection for SQL Server #736
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1060 We use Jira to track the state of pull requests and the versions they got |
Looks sane to me. Did you have a chance to test this on your setup, @deeky666? |
@Ocramius yes I tested this and it works. But it worked before for me, too so I have no clue why some people get an error there. Either way, this patch does no harm and system tables are documented lowercase in the SQL Server docs so this should be fine. |
Waiting for travis and then pressing zeh button |
@Ocramius thanks! |
Also to check: merge back to |
New test fails, sadly :-( |
It should also be backported to 2.5, not only to 2.4 |
6e9fd13
to
7e435c4
Compare
@Ocramius failing tests fixed now :) |
Looking good. Will merge today. |
…pection-for-sql-server-backport-to-2.5' into 2.5 Close #736
…pection-for-sql-server' Close #736
This won't be backported to 2.4.x due to conflicts - see http://www.doctrine-project.org/jira/browse/DBAL-1061 |
It looks like some SQL Server versions / setups need system tables to be queried lowercased otherwise causing errors.