Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBAL-1097] Fix foreign key constraint referential action on Oracle #760

Merged

Conversation

deeky666
Copy link
Member

Oracle only supports CASCADE and SET NULL referential actions for foreign key constraints. It also supports NO ACTION but it cannot be declared with an explicit ON DELETE NO ACTION clause. The complete clause has to be omitted in order to make it work.
This PR fixes supported referential actions and omits the referential clause if either action NO ACTION or RESTRICT is set for the foreign key constraint to create.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1097

We use Jira to track the state of pull requests and the versions they got
included in.

@deeky666
Copy link
Member Author

@deeky666
Copy link
Member Author

Related: #710

Ocramius added a commit that referenced this pull request Jan 1, 2015
[DBAL-1097] Fix foreign key constraint referential action on Oracle
@Ocramius Ocramius merged commit 608d2a2 into doctrine:master Jan 1, 2015
@Ocramius
Copy link
Member

Ocramius commented Jan 1, 2015

Merged!

2.6: 608d2a2
2.5: 185b886
2.4: 81591fd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants