Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBAL-1115] Fix quoted identifiers for database creation SQL on SQL Anywhere #773

Merged

Conversation

deeky666
Copy link
Member

In SQL Anywhere the statements CREATE DATABASE, DROP DATABASE, START DATABASE, STOP DATABASE always take unquoted identifiers.
This PR ensures given identifiers are always passed unquoted to the generated SQL.
This issue was discovered by using DoctrineBundle's database:create and database:drop commands which always quote the database identifiers.

$ php app/console doctrine:database:create
Could not create database for connection named "symfony"
An exception occurred while executing 'START DATABASE '"symfony"' AUTOSTOP OFF':

SQLSTATE [00000] [-82] Angegebene Datenbank konnte nicht gestartet werden: Illegal character in database alias.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1115

We use Jira to track the state of pull requests and the versions they got
included in.

@deeky666 deeky666 changed the title Fix quoted identifiers for database creation SQL on SQL Anywhere [DBAL-1115] Fix quoted identifiers for database creation SQL on SQL Anywhere Jan 13, 2015
Ocramius added a commit that referenced this pull request Jan 28, 2015
…abase-sql

[DBAL-1115] Fix quoted identifiers for database creation SQL on SQL Anywhere
@Ocramius Ocramius merged commit 8b848ea into doctrine:master Jan 28, 2015
Ocramius added a commit that referenced this pull request Jan 28, 2015
@Ocramius
Copy link
Member

Merged, thanks @deeky666!

master: 8b848ea
2.5: c6eaae5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants