Fix for inconsistent use of getSQLDeclaration #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed inconsistent use of getSqlDeclaration method name
Fixed inconsistent use of getSQLDeclaration method
Fixed inconsistent use of getSQLDeclaration method
Fixed inconsistent use of getSQLDeclaration method
Fixed inconsistent use of getSQLDeclaration method
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1169 We use Jira to track the state of pull requests and the versions they got |
Fixed inconsistent use of getSQLDeclaration method
|
@Wilt did this actually cause any issue or is it just for the sake of consistency? |
|
No bugs or anything dangerous, just for consistency and searchability. I tried to understand where and how this method was used and while searching (case sensitive) I noticed this... |
|
👍 |
Ocramius
added a commit
that referenced
this pull request
Mar 13, 2015
Fix for inconsistent use of getSQLDeclaration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an inconsistency in naming of the getSQLDeclaration method
I changed in 5 files
getSqlDeclaration->getSQLDeclarationPull request is related to : doctrine/orm#1329