[DBAL-1220] Fix dropping database with active connection on PostgreSQL #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1220 We use Jira to track the state of pull requests and the versions they got |
deeky666
changed the title
deeky666
added a commit
that referenced
this pull request
Aug 21, 2015
[DBAL-1220] Fix dropping database with active connection on PostgreSQL
j0k3r
added a commit
to wallabag/wallabag
that referenced
this pull request
Nov 6, 2015
For a not-clear reason, I can't properly drop the current database. Even if Doctrine made a special case for that (doctrine/dbal#849). So instead of trying crazy things to achieve the test, better way is to skip test (too much wasted days ..)
j0k3r
added a commit
to wallabag/wallabag
that referenced
this pull request
Nov 7, 2015
For a not-clear reason, I can't properly drop the current database. Even if Doctrine made a special case for that (doctrine/dbal#849). So instead of trying crazy things to achieve the test, better way is to skip test (too much wasted days ..)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL fails to drop a database if there are active connections using that particular database.
This PR closes all active connections before dropping the database if dropping the database failed before.