Quote table and constraint names in drop foreign key / drop constraint SQL #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the MySQLPlatform::getDropForeignKeySQL table name will not be escaped if the name is passed instead of the object table itself. Since the getLocalTableName use the localTable property the object is always available, there is no reason not to use it.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1237 We use Jira to track the state of pull requests and the versions they got |
|
Requires a test case. |
deeky666
added
Quoting
SQL Server
Oracle
IBM DB2
Drizzle
PostgreSQL
SQL Anywhere
Azure
labels
deeky666
changed the title
deeky666
added a commit
that referenced
this pull request
Jan 9, 2016
Quote table and constraint names in drop foreign key / drop constraint SQL fixes #1186
|
Merge manually via 50f4482. Added quotation fixed in the platforms, too and fixed failing test due to this patch. |
|
Hey, this also affects Postgres. I was a bit surprised to see that the fix has existed for 9 months already - is there a rough estimate on when it will be tagged? Keep up the great work! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the MySQLPlatform::getDropForeignKeySQL table name will not be escaped if the name is passed instead of the object table itself.
Since the getLocalTableName use the localTable property the object is always available, there is no reason not to use it.