Fix undefined notices within MasterSlaveConnection #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix the following notice-level errors: Notice: Undefined property: Doctrine\DBAL\Connections\MasterSlaveConnection::$_conn in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php line 154 Notice: Undefined index: slave in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php line 165
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1240 We use Jira to track the state of pull requests and the versions they got |
guilhermeblanco
added a commit
that referenced
this pull request
May 22, 2015
Fix undefined notices within MasterSlaveConnection
| @@ -151,7 +151,7 @@ public function connect($connectionName = null) | |||
| // If we have a connection open, and this is not an explicit connection | |||
| // change request, then abort right here, because we are already done. | |||
| // This prevents writes to the slave in case of "keepSlave" option enabled. | |||
| if ($this->_conn && !$requestedConnectionChange) { | |||
| if (isset($this->_conn) && $this->_conn && !$requestedConnectionChange) { | |||
There was a problem hiding this comment.
this change is wrong IMO. The property exists in the class (we already fixed the bug unsetting the property rather than the value previously), and the case of null is already covered by the condition before the patch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the following notice-level errors:
Notice: Undefined property: Doctrine\DBAL\Connections\MasterSlaveConnection::$_conn in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php line 154
Notice: Undefined index: slave in vendor/doctrine/dbal/lib/Doctrine/DBAL/Connections/MasterSlaveConnection.php line 165