Can't instantiate final class extending ArrayIterator

[ciaranmcnulty]

final class Foo extends ArrayIterator
{
}

(new \Doctrine\Instantiator\Instantiator()->instantiate(Foo::class);

PHP Fatal error:  Uncaught Exception: unserialize(): Error at offset 13 of 14 bytes in /Users/cmcnulty/Documents/Code/phpspec/vendor/doctrine/instantiator/src/Doctrine/Instantiator/Exception/UnexpectedValueException.php:76

Reproduced on 1.0.5 and 1.1.0 and, not had a chance to debug. Was reported to PhpSpec as phpspec/phpspec#1124

[Ocramius]

Is the class being final a required factor?

…

On 15 Oct 2017 13:07, "Ciaran McNulty" ***@***.***> wrote: final class Foo extends ArrayIterator { } return (new \Doctrine\Instantiator\Instantiator())->instantiate(Foo::class); PHP Fatal error: Uncaught Exception: unserialize(): Error at offset 13 of 14 bytes in /Users/cmcnulty/Documents/Code/phpspec/vendor/doctrine/instantiator/src/Doctrine/Instantiator/Exception/UnexpectedValueException.php:76 Reproduced on 1.0.5 and 1.1.0 and, not had a chance to debug. Was reported to PhpSpec as phpspec/phpspec#1124 <phpspec/phpspec#1124> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#39>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakE774PThopb7rIeL4MKZ-Y_s5Exuks5ssedcgaJpZM4P5tar> .

[ciaranmcnulty]

non-final doesn't reproduce the error

[ciaranmcnulty]

Yep final makes it go back to the unserialization strategy, which seems to have an issue with the ArrayIterator

(that is, if I try to unserializing the generated string the final doesn't make a diff)

https://3v4l.org/1dYQD

[mikeSimonson]

@ciaranmcnulty This seems to be a hhvm serialization bug. https://3v4l.org/1dYQD

[ciaranmcnulty]

Waaait, is it that it's working fine but the error handler is catching the notice?

[Ocramius]

It is supposed to catch, otherwise internal state may be broken

…

On 17 Oct 2017 06:36, "Ciaran McNulty" ***@***.***> wrote: Waaait, is it that it's working fine but the error handler is catching the notice? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakDnR52cVKEBbHmQP7ULXiNZ2t017ks5stC7JgaJpZM4P5tar> .

[mikeSimonson]

note that with that class that extends ArrayIterator
This works in PHP and thow a notice in hhvm

unserialize('C:3:"Foo":0:{}')

And This works in hhvm and breaks in PHP

unserialize('O:3:"Foo":0:{}')

[Ocramius]

@mikeSimonson what is the resolution here?

[ciaranmcnulty]

I was wondering too :-)

If it’s “won’t fix” can you say explicitly so we can plan how we handle this error being thrown?

[Ocramius]

Needs clarification. I'm fine with dropping HHVM support and having a workaround just for ArrayIterator if anybody has an idea of how to get there :P

[ciaranmcnulty]

The fact it works differently in HHVM is a red herring IMO

the final is excluding the Reflection strategy for creating the object

The fact it extends ArrayObject means it somehow can't be deserialized from a string starting with c: but I don't know enough about serialization to suggest why (I tried to read http://www.phpinternalsbook.com/classes_objects/serialization.html#serializing-internal-objects and my eyes got tired)

[ciaranmcnulty]

As a side note I very much doubt specific serialization formats are at all going to be thought about in terms of BC when PHP changes things :-/

[mikeSimonson]

Sorry that it wasn't clear enough.

In my tests the only way to serialize the sample code in https://3v4l.org/1dYQD to 'O:3:"Foo":0:{}' is to use hhvm. And hhvm (HHVM-3.22.1) can unserialize that on my machine without any notice or error. https://3v4l.org/eX9TO

It just failed trying to unserialize hhvm serialization in php. Which seemed like a edge case to me.

That's the reason I closed it.

But maybe that's not was is going on in your case ?

[ciaranmcnulty]

I'm not using HHVM, no

[mikeSimonson]

Then, how did you ended up with the 'O:3:"Foo":0:{}' serialized string ?

[ciaranmcnulty]

I was debugging my failure case and it was generated by Doctrine/Instantiator here:

https://github.com/doctrine/instantiator/blob/master/src/Doctrine/Instantiator/Instantiator.php#L104-L105

[gquemener]

This issue can now be closed 🎉

[Ocramius]

Fixed in #61