CS 4.0, PHPStan 0.9, PHPUnit 7, static asserts, composer.lock, merged stages #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
force-pushed
the
cs-4.0&phpstan-0.9&phpunit7&version-lockfile
branch
from
1fda269 to
4f8a477
Compare
Majkl578
force-pushed
the
cs-4.0&phpstan-0.9&phpunit7&version-lockfile
branch
from
4f8a477 to
a190f41
Compare
Majkl578
force-pushed
the
cs-4.0&phpstan-0.9&phpunit7&version-lockfile
branch
from
a190f41 to
62dc422
Compare
Majkl578
changed the title
Majkl578
changed the title
Majkl578
force-pushed
the
cs-4.0&phpstan-0.9&phpunit7&version-lockfile
branch
2 times, most recently
from
34d0205 to
b288091
Compare
|
Hmm I think I totally confused Composer with this crazy branch name, had to do fixups in different normal branch & do reset... Really strange. |
carusogabriel
suggested changes
Mar 5, 2018
phpstan.tests.neon
Outdated
| @@ -1,3 +1,6 @@ | |||
| parameters: | |||
| ignoreErrors: | |||
| - '#::__construct\(\) does not call parent constructor from#' | |||
|
|
|||
| # dynamic properties consufe static analysis | |||
| $this->instantiator->instantiate('DoctrineTest\\InstantiatorTestAsset\\SimpleSerializableAsset'); | ||
| $this->instantiator->instantiate('DoctrineTest\\InstantiatorTestAsset\\SerializableArrayObjectAsset'); | ||
| $this->instantiator->instantiate('DoctrineTest\\InstantiatorTestAsset\\UnCloneableAsset'); | ||
| $this->instantiator->instantiate(self::class); |
There was a problem hiding this comment.
Do we have a rule for this changes?
-__CLASS__
+self::classThere was a problem hiding this comment.
Because other places already use ::class, and just because it's better. :D
There was a problem hiding this comment.
Tbh, I'd fancy such a rule - it would remove the ambiguity once and for all 👍
Majkl578
force-pushed
the
cs-4.0&phpstan-0.9&phpunit7&version-lockfile
branch
from
b288091 to
7831db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class naming rules ignored as no changes to the class names in stable are possible.