Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax suggested version. #5

Merged
merged 1 commit into from
Aug 18, 2014
Merged

Relax suggested version. #5

merged 1 commit into from
Aug 18, 2014

Conversation

whatthejeff
Copy link
Contributor

@GrahamCampbell
Copy link
Contributor

Would ~1.0,>=1.0.1 be better? ie - without the extra spaces?

@whatthejeff
Copy link
Contributor Author

@GrahamCampbell Fixed :)

@Ocramius
Copy link
Member

A bit complex for no real gain no? I don't really plan to add any features to this lib for now...

@Ocramius
Copy link
Member

Meh, nvm, it's copy-pasted code for the user anyway - merging :-)

@Ocramius Ocramius self-assigned this Aug 18, 2014
@Ocramius Ocramius added this to the 1.0.2 milestone Aug 18, 2014
Ocramius added a commit that referenced this pull request Aug 18, 2014
@Ocramius
Merge pull request #5 from whatthejeff/patch-1
337e872 
Relax suggested version.
@Ocramius Ocramius merged commit 337e872 into doctrine:master Aug 18, 2014
@whatthejeff
Copy link
Contributor Author

Thanks, @Ocramius :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@whatthejeff @GrahamCampbell @Ocramius