Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated doctrine/coding-standard to 6.0 #58

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Updated doctrine/coding-standard to 6.0 #58

merged 1 commit into from
Mar 17, 2019

Conversation

patrickjahns
Copy link
Contributor

Updated the coding-standard - run phpcs to check if we need any further adjustments - everything is ✅

Signed-off-by: Patrick Jahns <github@patrickjahns.de>
@Ocramius Ocramius merged commit a2c5901 into doctrine:master Mar 17, 2019
@Ocramius Ocramius self-assigned this Mar 17, 2019
@Ocramius Ocramius added this to the 1.2.0 milestone Mar 17, 2019
@patrickjahns patrickjahns deleted the bump-coding-standard-6.0 branch March 17, 2019 17:56
@carusogabriel
Copy link

@patrickjahns I believe you forgot to run composer update doctrine/coding-standard --with-dependencies 😄

@patrickjahns
Copy link
Contributor Author

@carusogabriel
Thanks for the hint - I purposely only bumped the related dependencies explicitly - similar to:

 composer update doctrine/coding-standard squizlabs/php_codesniffer dealerdirect/phpcodesniffer-composer-installer phpstan/phpdoc-parser slevomat/coding-standard

I didn't want to drag in other dependency updates - but can do so if you want me to 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants