Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Composer files are valid #66

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

greg0ire
Copy link
Member

They often get out of sync, which can lead to non-obvious issues.

@greg0ire
Copy link
Member Author

greg0ire commented Feb 10, 2020

This first commit should fail the build.

EDIT: It did!

7.1.27 is what Travis uses in its 7.1 build, which we use in the Code
  quality step.
They often get out of sync, which can lead to non-obvious issues.
@greg0ire greg0ire force-pushed the validate-composer-json branch from 3ee80e8 to 5a76dee Compare February 10, 2020 19:31
@alcaeus alcaeus merged commit 0660999 into doctrine:1.3.x Feb 10, 2020
@alcaeus
Copy link
Member

alcaeus commented Feb 10, 2020

Thanks @greg0ire!

@greg0ire greg0ire deleted the validate-composer-json branch February 10, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants