Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against PHP 8 #68

Merged
merged 3 commits into from
May 29, 2020
Merged

Test against PHP 8 #68

merged 3 commits into from
May 29, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented May 25, 2020

No description provided.

@alcaeus alcaeus added this to the 1.3.1 milestone May 25, 2020
@alcaeus alcaeus requested a review from greg0ire May 25, 2020 19:54
@greg0ire
Copy link
Member

Something went very wrong, not sure what… TIL phpunit/phpunit depends on this package. Isn't there COMPOSER_ROOT_VERSION magic required for this to work?

greg0ire
greg0ire reviewed May 25, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
greg0ire
greg0ire reviewed May 26, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
@greg0ire
Copy link
Member

Isn't there COMPOSER_ROOT_VERSION magic required for this to work?

Link to PR with said magic: github.com/doctrine/reflection/pull/37

@alcaeus alcaeus self-assigned this May 29, 2020
@alcaeus
Copy link
Member Author

alcaeus commented May 29, 2020

COMPOSER_ROOT_VERSION did the trick and we've now got a stable PHP 8 build (although I'd still keep allowed_failures` for a while).

@alcaeus alcaeus requested a review from greg0ire May 29, 2020 14:12
@greg0ire greg0ire merged commit f350df0 into 1.3.x May 29, 2020
@greg0ire greg0ire deleted the php-8 branch May 29, 2020 17:27
@greg0ire
Copy link
Member

Thanks @alcaeus !

@doctrinebot doctrinebot mentioned this pull request May 30, 2020
Merged
@greg0ire greg0ire mentioned this pull request Nov 9, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees

@alcaeus alcaeus

Labels
enhancement
Projects
None yet
Milestone
1.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @greg0ire