Migrate codebase to PHP 8.1 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Dec 29, 2022
Comment on lines
+32
to
+35
| private const SERIALIZATION_FORMAT_USE_UNSERIALIZER = 'C'; | ||
| private const SERIALIZATION_FORMAT_AVOID_UNSERIALIZER = 'O'; |
There was a problem hiding this comment.
Those constants are never used publicly and I believe they should not be part of the public interface. Do we need to flag them as deprecated on 1.x or is it enough to just switch them to private in 2.0?
There was a problem hiding this comment.
Let's flag them as deprecated out of consistency with doctrine/orm#10342?
greg0ire
approved these changes
Dec 29, 2022
derrabus
force-pushed
the
bump/php-8.1
branch
from
e4a3e60
to
c8a186d
Compare
stof
reviewed
Jan 4, 2023
| @@ -31,37 +31,33 @@ final class Instantiator implements InstantiatorInterface | |||
| * | |||
| * @deprecated This constant will be private in 2.0 | |||
There was a problem hiding this comment.
you forgot to remove that @deprecated tag
There was a problem hiding this comment.
Right. Wanna submit a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's give this little library its PHP 8.1 treatment.
If this PR gets accepted, I'll create a 2.0.x branch and merge it there.Replaces #44