[2.0] Drop commands to generate repository and entity stubs #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
drop-entity-generator
branch
from
20d4763 to
c82ad41
Compare
malarzm
reviewed
Dec 23, 2017
|
|
||
| if (count($metadatas)) { | ||
| // Create DocumentGenerator | ||
| $documentGenerator = new DocumentGenerator(); |
There was a problem hiding this comment.
DocumentGenerator and related tests should be removed too, no?
|
Almost -2k - that's a gain! FTR I can't merge due to conflict :( |
alcaeus
force-pushed
the
drop-entity-generator
branch
from
f7254dd to
cd90c54
Compare
|
My bad - fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation in 1.3 will come once we have the appropriate branch.