Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ::class where possible #1770

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Use ::class where possible #1770

merged 1 commit into from
Apr 4, 2018

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Apr 3, 2018

This isn't even my final form

carusogabriel
carusogabriel suggested changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malarzm What did you use to do it? Something we can apply to Doctrine's CS?

tests/Doctrine/ODM/MongoDB/Tests/Functional/Ticket/GH936Test.php Outdated

$this->assertInstanceOf('Doctrine\ODM\MongoDB\Proxy\Proxy', $foo->ref);
$this->assertInstanceOf(\Doctrine\ODM\MongoDB\Proxy\Proxy::class, $foo->ref);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS is breaking here. This should be referenced via use 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching 👍

@malarzm
Copy link
Member Author

malarzm commented Apr 4, 2018

What did you use to do it? Something we can apply to Doctrine's CS?

@carusogabriel sadly it was manual work

@malarzm malarzm changed the title [WIP] Use ::class where possible Use ::class where possible Apr 4, 2018
@malarzm
Copy link
Member Author

malarzm commented Apr 4, 2018

Chances are this is everything: some occurrences were left on purpose, some might have been missed. @carusogabriel I did separate commit on purpose in case you were reading the changes, after accepting I'll squash commits

carusogabriel
carusogabriel approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

I’ll search for a Fixer or something to do this jobs for us, isn’t fair to do it by hand!

@malarzm malarzm merged commit 115f1d0 into doctrine:master Apr 4, 2018
@malarzm malarzm deleted the class-const branch April 4, 2018 13:04
@malarzm malarzm mentioned this pull request Apr 4, 2018
Closed
@alcaeus alcaeus added this to the 2.0.0-Beta1 milestone Dec 19, 2018
@alcaeus alcaeus added the Task label Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@malarzm @carusogabriel @alcaeus