Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Test update: ODM no longer supports PHP < 7.2 #1847

Merged
merged 2 commits into from
Aug 10, 2018
Merged

[2.0] Test update: ODM no longer supports PHP < 7.2 #1847

merged 2 commits into from
Aug 10, 2018

Conversation

caciobanu
Copy link
Contributor

Q A
Type improvement
BC Break no
Fixed issues partial #1791

alcaeus
alcaeus approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I assume you also checked for other occurences?

@caciobanu
Copy link
Contributor Author

Yes, I did a search. I have to fix the CS failure and it will be all good.

@caciobanu
Copy link
Contributor Author

Done.

@alcaeus alcaeus merged commit a4b3c82 into doctrine:master Aug 10, 2018
@alcaeus
Copy link
Member

alcaeus commented Aug 10, 2018

Thanks @caciobanu!

@alcaeus alcaeus added this to the 2.0.0 milestone Aug 10, 2018
@alcaeus alcaeus added the Task label Aug 10, 2018
@alcaeus alcaeus self-assigned this Aug 10, 2018
@caciobanu caciobanu deleted the update-tests branch August 10, 2018 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@alcaeus alcaeus

Labels
Task
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
2 participants
@caciobanu @alcaeus