Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate index creation options from index options #1910

Merged
merged 5 commits into from
Dec 24, 2018
Merged

Separate index creation options from index options #1910

merged 5 commits into from
Dec 24, 2018

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Dec 19, 2018 •
edited
Loading

Q A
Type improvement
BC Break yes
Fixed issues #841

Summary

  • Dropped the dropDups option for indexes since MongoDB no longer uses it
  • Dropped the timeout command line option for schema commands
  • Added maxTimeMS and writeConcern options to schema manager
  • Exposed maxTimeMS as well as w, wTimeout and journal options to schema commands

@alcaeus alcaeus added this to the 2.0.0-Beta1 milestone Dec 19, 2018
@alcaeus alcaeus self-assigned this Dec 19, 2018
@alcaeus alcaeus requested a review from jmikola December 19, 2018 14:03
@alcaeus
Copy link
Member Author

alcaeus commented Dec 20, 2018

Note: I extracted index equivalency checks from this PR to a separate branch and will be opening a PR for that shortly. I feel those changes warrant their own discussion.

@alcaeus alcaeus mentioned this pull request Dec 20, 2018
Merged
malarzm
malarzm approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks OK 👍

@alcaeus
Harden checks for writeConcern options
9e05a40 
* Throw an exception when wTimeout or journal are passed without a w option
* Cast w to int if it's numeric to ensure correct handling of writeConcern values in the driver
@alcaeus alcaeus merged commit 126e103 into doctrine:master Dec 24, 2018
@alcaeus alcaeus deleted the drop-index-options branch December 24, 2018 09:28
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate timeout options in schema commands (doctrine#1910)
da2d455
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate dropDups option on indexes (doctrine#1910)
bae33e3
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate indexOptions argument in SchemaManager (doctrine#1910)
8e8dbea
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate timeout options in schema commands (doctrine#1910)
6b18ed7
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate dropDups option on indexes (doctrine#1910)
ecf25d2
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate indexOptions argument in SchemaManager (doctrine#1910)
cc73618
@alcaeus alcaeus mentioned this pull request Jan 11, 2019
Merged
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate dropDups option on indexes (doctrine#1910)
3f37f79
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 11, 2019
@alcaeus
Deprecate indexOptions argument in SchemaManager (doctrine#1910)
dae11db
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 14, 2019
@alcaeus
Deprecate timeout options in schema commands (doctrine#1910)
b659ee7
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 14, 2019
@alcaeus
Deprecate dropDups option on indexes (doctrine#1910)
092c0a1
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Jan 14, 2019
@alcaeus
Deprecate indexOptions argument in SchemaManager (doctrine#1910)
55d5f33
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Mar 6, 2019
@alcaeus
Merge branch '1.3.x'
8acd867 
* 1.3.x: (65 commits)
  Clarify deprecation block for same-namespace resolution
  Add BC layer for optimized collection operations
  Updated existing tests for CollectionPersister for tracking executed queries where it is required. Added missing tests for checking simultaneous embed-many collections updates under different storage strategies.
  Simplified methods for working with nested collections, remove redundant checks
  Merge remarks implemented.
  Reduced complexity of CollectionPersister::excludeSubPaths method.
  Updated CollectionPersister logic for handling nested collections scheduled for update - now nested collections for one parent is updated inside one query where it was possible.
  Added check for sub-paths before collections removal in CollectionPersister::deleteAll. Fixed style of code.
  Implemented CollectionPersister::deleteAll method for simultaneous deletion of collections that is belong to one document.
  Deprecate GridFS features
  Deprecate proxies from doctrine/common
  Finish renaming dirtyCheck methods
  Remove usage of deprecated ClassMetadataInfo class in hydrators
  Renamed scheduledForDirtyCheck
  Removed PHP 5.5 workaround
  Add changelog for 1.2.6
  Fix wrong type hint for generator type in ClassMetadata
  Fix serialisation of uninitialised PersistentCollection instances
  Deprecate indexOptions argument in SchemaManager (doctrine#1910)
  Deprecate dropDups option on indexes (doctrine#1910)
  ...
alcaeus added a commit to alcaeus/mongodb-odm that referenced this pull request Mar 8, 2019
@alcaeus
Merge branch '1.3.x'
3bf3ceb 
* 1.3.x: (65 commits)
  Clarify deprecation block for same-namespace resolution
  Add BC layer for optimized collection operations
  Updated existing tests for CollectionPersister for tracking executed queries where it is required. Added missing tests for checking simultaneous embed-many collections updates under different storage strategies.
  Simplified methods for working with nested collections, remove redundant checks
  Merge remarks implemented.
  Reduced complexity of CollectionPersister::excludeSubPaths method.
  Updated CollectionPersister logic for handling nested collections scheduled for update - now nested collections for one parent is updated inside one query where it was possible.
  Added check for sub-paths before collections removal in CollectionPersister::deleteAll. Fixed style of code.
  Implemented CollectionPersister::deleteAll method for simultaneous deletion of collections that is belong to one document.
  Deprecate GridFS features
  Deprecate proxies from doctrine/common
  Finish renaming dirtyCheck methods
  Remove usage of deprecated ClassMetadataInfo class in hydrators
  Renamed scheduledForDirtyCheck
  Removed PHP 5.5 workaround
  Add changelog for 1.2.6
  Fix wrong type hint for generator type in ClassMetadata
  Fix serialisation of uninitialised PersistentCollection instances
  Deprecate indexOptions argument in SchemaManager (doctrine#1910)
  Deprecate dropDups option on indexes (doctrine#1910)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola left review comments

@malarzm malarzm malarzm approved these changes

Assignees

@alcaeus alcaeus

Labels
BC Break Feature
Projects
None yet
Milestone
2.0.0-Beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@alcaeus @jmikola @malarzm