Make addStage Aggregation Builder method public #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
make-add-stage-public
branch
from
2be5375
to
0571cc0
Compare
Co-authored-by: Andreas Braun <git@alcaeus.org>
malarzm
approved these changes
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This takes work done by @Steveb-p in #1974 and applies it to the master branch. As explained in #1974 (comment), without a public
addStagemethod in the pipeline stages we can't really make it public in the builder either since it would break the fluent interface, which might confuse people. In order to avoid having to do a new minor release ofdoctrine/mongodbjust to make the method public, we move the feature to the 2.0 release.