Fix wrong initialisation of proxies with public properties #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Oct 8, 2019
alcaeus
force-pushed
the
fix-wrong-proxy-initialisation
branch
from
f54d694
to
0ecbd08
Compare
malarzm
approved these changes
Oct 8, 2019
Ocramius
approved these changes
Oct 8, 2019
|
Thanks for the fix! And it'd be nice if these changes can land in release asap since it's blocking my upgrade process :P |
alcaeus
force-pushed
the
fix-wrong-proxy-initialisation
branch
from
0ecbd08
to
6395ff4
Compare
|
Thanks @alcaeus! |
2.0.1 has been released: https://github.com/doctrine/mongodb-odm/releases/tag/2.0.1 |
|
@alcaeus Thanks for the release! |
|
From what I can see the test I added covers yours, so you don't need to bother cleaning it up ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where hydrating a proxy object will not initialise any properties that aren't passed to the hydrator. With this fix, we invoke proxy initialisation with an empty initialiser so we initialise an empty object before adding any data.