Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusable Match classes #2557

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove unusable Match classes #2557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions UPGRADE-2.6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,12 @@

* MongoDB ODM 2.6 requires PHP 8.1 or newer. If you're not running PHP 8.1 yet,
it's recommended that you upgrade to PHP 8.1 before upgrading ODM.

## `Match` classes were removed

Minimal requirement of PHP 8.1 has rendered `Match` classes useless as one may
not use them for backward compatibility purposes as `match` is a reserved keyword.

Following classes were removed:
- `\Doctrine\ODM\MongoDB\Aggregation\Stage\GraphLookup\Match`
- `\Doctrine\ODM\MongoDB\Aggregation\Stage\Match`
29 changes: 0 additions & 29 deletions lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
<exclude-pattern>tests/PersistentCollections*</exclude-pattern>
<!-- Figure out what to do with "Scope keyword "static" must be followed by a single space; found newline" -->
<exclude-pattern>tests/Doctrine/ODM/MongoDB/Tests/PersistentCollection/CollWithPHP80Types.php</exclude-pattern>
<exclude-pattern>lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php</exclude-pattern>
<exclude-pattern>lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php</exclude-pattern>
<!-- Figure out what to do with PHP 8.1 errors in coding standard -->
<exclude-pattern>tests/Doctrine/ODM/MongoDB/Tests/PersistentCollection/CollWithPHP81Types.php</exclude-pattern>

Expand Down
2 changes: 0 additions & 2 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ parameters:
- lib
- tests
excludePaths:
- lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php
- lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php
- tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/fixtures/User.php
- tests/Hydrators/
- tests/PersistentCollections/
Expand Down
4 changes: 0 additions & 4 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
<include>
<directory suffix=".php">./lib/Doctrine/ODM/MongoDB</directory>
</include>
<exclude>
<file>./lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php</file>
<file>./lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php</file>
</exclude>
</coverage>
<groups>
<exclude>
Expand Down
2 changes: 0 additions & 2 deletions psalm.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
<directory name="tests/Doctrine" />
<directory name="tests/Documents" />
<ignoreFiles>
<file name="lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup/Match.php" />
<file name="lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Match.php" />
<file name="tests/Doctrine/ODM/MongoDB/Tests/Mapping/Driver/fixtures/User.php" />
<directory name="vendor" />
</ignoreFiles>
Expand Down
Loading