Bump workflows #2566
Merged
Bump workflows #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
bump_workflows
branch
2 times, most recently
from
9d2cc87 to
9e9d6dd
Compare
malarzm
reviewed
Oct 29, 2023
| @@ -8,7 +8,7 @@ on: | |||
| jobs: | |||
| release: | |||
| name: "Git tag, release & create merge-up PR" | |||
| uses: "doctrine/.github/.github/workflows/release-on-milestone-closed.yml@1.4.1" | |||
| uses: "doctrine/.github/.github/workflows/release-on-milestone-closed.yml@3.1.0" | |||
There was a problem hiding this comment.
Anything we need to do bumping two majors?
There was a problem hiding this comment.
Apparently not:
2.0: https://github.com/doctrine/.github/releases/tag/2.0.0 was to set PHP 8.1 by default
3.0: https://github.com/doctrine/.github/releases/tag/3.0.0 was to set PHP 8.2 by default and run on ubuntu 22.04
Following ORM, here updated to 2.0 and here to 3.0
Looking at this, we can use ubuntu 22.04 as well, I'll add those changes in this PR
franmomu
force-pushed
the
bump_workflows
branch
4 times, most recently
from
9993147 to
495ca6b
Compare
franmomu
force-pushed
the
bump_workflows
branch
from
495ca6b to
da55343
Compare
malarzm
approved these changes
Oct 30, 2023
|
Thanks @franmomu! |
|
Thanks @franmomu! For the record, dependabot can automatically update GitHub Actions Workflows, and we might want to leverage this here as well. See mongodb/mongo-php-library#1157 for an example :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.