Modernize generated code for Hydrators #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Jul 1, 2024
Comment on lines
+373
to
+375
| use function array_key_exists; | ||
| use function gettype; | ||
| use function is_array; |
There was a problem hiding this comment.
This functions are compiler-optimized.
| \$this->dm = \$dm; | ||
| \$this->class = \$class; | ||
| } | ||
| public function __construct(private DocumentManager \$dm, private ClassMetadata \$class) {} |
There was a problem hiding this comment.
Adding the property type.
Comment on lines
+384
to
+386
| public function hydrate(object \$document, array \$data, array \$hints = []): array | ||
| { | ||
| \$hydratedData = array(); | ||
| \$hydratedData = []; |
| @@ -167,8 +167,8 @@ private function generateHydratorClass(ClassMetadata $class, string $hydratorCla | |||
| $code .= sprintf( | |||
| <<<EOF | |||
|
|
|||
| /** @AlsoLoad("$name") */ | |||
| if (!array_key_exists('%1\$s', \$data) && array_key_exists('$name', \$data)) { | |||
| // AlsoLoad("$name") | |||
There was a problem hiding this comment.
Reference to doctrine annotations is outdated.
malarzm
approved these changes
Jul 1, 2024
alcaeus
added a commit
that referenced
this pull request
Sep 6, 2024
* 2.9.x: (24 commits) Fix typo in code example (#2670) Label PRs about GH actions with "CI" (#2632) Review basic mapping (#2668) Fix wording (#2667) Add native type to private properties and final classes (#2666) Review and add tests on `ResolveTargetDocumentListener` (#2660) Remove soft-delete-cookbook (#2657) doc: Remove wakeup and clone cookbook (#2663) Modernize generated code for Hydrators (#2665) Add tests for introduction (#2664) doc: Review mapping ORM and ODM cookbook (#2658) doc: Review cookbook on blending ORM and ODM (#2656) doc: Review and test validation cookbook (#2662) Update custom mapping example (#2654) doc: Review Simple Search Engine Cookbook (#2659) doc: Add cookbook about embedding referenced documents using $lookup (#2655) doc: Add type to properties (#2652) doc: Review custom collections and repository docs (#2653) doc: Review Getting Started (#2650) Move annotations-reference to attributes-reference (#2651) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use functionstatement for compiler-optimized functions