This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Add support for $setOnInsert operator #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -177,7 +177,6 @@ public function testFindQuery() | |||
| public function testUpsertUpdateQuery() | |||
| { | |||
| $qb = $this->getTestQueryBuilder() | |||
| ->update() | |||
There was a problem hiding this comment.
wasn't this test checking if upsert overrides previous update?
There was a problem hiding this comment.
You're correct. I've had half a mind of making upserts imply an update but then I changed my mind and forgot to change this back. Fixed now.
malarzm
added a commit
that referenced
this pull request
Oct 31, 2015
Add support for $setOnInsert operator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the $setOnInsert operator that was added in MongoDB 2.4.