Remove calls to prefersSequences()

doctrine · Aug 4, 2021 · ca8b67b · ca8b67b
1 parent e09f126
commit ca8b67b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 10 deletions.
diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php b/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php
@@ -43,6 +43,7 @@
 use function explode;
 use function in_array;
 use function is_subclass_of;
+use function method_exists;
 use function strpos;
 use function strtolower;
 
@@ -548,10 +549,12 @@ private function completeIdGeneratorMapping(ClassMetadataInfo $class): void
     {
         $idGenType = $class->generatorType;
         if ($idGenType === ClassMetadata::GENERATOR_TYPE_AUTO) {
-            if ($this->getTargetPlatform()->prefersSequences()) {
+            if (method_exists(AbstractPlatform::class, 'prefersSequences') && $this->getTargetPlatform()->prefersSequences()) {
                 $class->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_SEQUENCE);
-            } elseif ($this->getTargetPlatform()->prefersIdentityColumns()) {
+            } elseif ($this->getTargetPlatform()->supportsIdentityColumns()) {
                 $class->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_IDENTITY);
+            } elseif ($this->getTargetPlatform()->supportsSequences()) {
+                $class->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_SEQUENCE);
             } else {
                 $class->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_TABLE);
             }

diff --git a/tests/Doctrine/Tests/Mocks/DatabasePlatformMock.php b/tests/Doctrine/Tests/Mocks/DatabasePlatformMock.php
@@ -20,18 +20,22 @@ class DatabasePlatformMock extends AbstractPlatform
     /** @var bool */
     private $_prefersSequences = false;
 
-    /**
-     * {@inheritdoc}
-     */
-    public function prefersIdentityColumns()
+    public function prefersIdentityColumns(): bool
     {
         return $this->_prefersIdentityColumns;
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    public function prefersSequences()
+    public function supportsIdentityColumns(): bool
+    {
+        return $this->_prefersIdentityColumns;
+    }
+
+    public function prefersSequences(): bool
+    {
+        return $this->_prefersSequences;
+    }
+
+    public function supportsSequences(): bool
     {
         return $this->_prefersSequences;
     }