Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow override of inherited property #10289

Closed
michnovka opened this issue Dec 11, 2022 · 2 comments
Closed

Disallow override of inherited property #10289

michnovka opened this issue Dec 11, 2022 · 2 comments

Comments

@michnovka
Copy link
Contributor

I came across #8348 and I found in current code we still have

orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

Lines 2632 to 2635 in b25561a

//if (isset($mapping['inherited'])) {
// TODO: Enable this exception in 2.8
//throw MappingException::illegalOverrideOfInheritedProperty($this->name, $fieldName);
//}

I think that this exception should be thrown here, don't you think? @beberlei
@mpdude
Copy link
Contributor

mpdude commented Jan 19, 2023

I think pointing out configurations that are not officially supported and only work by chance is a good thing to do. Hopefully it works towards bringing down the number of bug reports for dubious use cases.

What about creating a PR for this? Are there tests already?

mpdude added a commit to mpdude/doctrine2 that referenced this issue Jan 26, 2023
@mpdude
Trigger a deprecation notice when entity fields/associations are over…
a4ca839 
…ridden

This was brought up in doctrine#8348, but seemingly forgotten to be implenented in later versions.

Closes doctrine#10289.
@mpdude mpdude mentioned this issue Jan 26, 2023
Merged
mpdude added a commit to mpdude/doctrine2 that referenced this issue Feb 9, 2023
@mpdude
Trigger a deprecation notice when entity fields/associations are over…
c9b644d 
…ridden

This was brought up in doctrine#8348, but seemingly forgotten to be implenented in later versions.

Closes doctrine#10289.
@mpdude
Copy link
Contributor

mpdude commented Feb 13, 2023

#10470 solved this, please close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greg0ire @mpdude @michnovka