update help for RunDqlCommand #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
force-pushed
the
update_help
branch
from
73e42b1 to
3da9d01
Compare
greg0ire
reviewed
Nov 15, 2022
stof
approved these changes
Nov 15, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 20, 2022
* 2.14.x: Remove fragile assertions (doctrine#10239) update help for RunDqlCommand (doctrine#10233) Make the code easier to statically analyse Widen parameter type Document property as non-nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of deprecating all commands on DoctrineBundle that are just extending the ORM command classes without adding anymore functionality.
We noticed that for the
RunDqlCommandthe help text on the DoctrineBundle command seems a bit more helpful.So I'm proposing to update the help text here with what we have on DoctrineBundle.
See doctrine/DoctrineBundle#1581