Move psalm types to ClassMetadata #10478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spares us from referencing ClassMetadataInfo from other classes, which is a good thing since it is deprecated. It also means merging up is easier.
greg0ire
force-pushed
the
better-psalm-type-location
branch
from
81f4c66 to
6c925f5
Compare
derrabus
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spares us from referencing
ClassMetadataInfofrom other classes, which is a good thing since it is deprecated. It also means merging up is easier.This prepares a change where I plan to use array shapes a lot more, based on the learnings from #10405