Fix forgotten exception throws

[janedbal]

I believe those exceptions are meant to be thrown, right? Otherwise, this code is useles.

Detected by https://github.com/shipmonk-rnd/phpstan-rules#forbidunusedexception

[greg0ire]

Oh wow good catch! I'm pretty careless sometimes 🤦

[greg0ire]

Argh it breaks the test suite… somehow we are relying on this feature, which does not work with Persistence 3, and somehow that did not break the tests before 😓

I should have changed them in #9592

[greg0ire]

I'm looking into it.

[janedbal]

@greg0ire Do you want me to send PR with this rule enabled to make sure this error wont happen again? It is pretty common error actually :)

[greg0ire]

@janedbal I think adding a dependency for one rule isn't a great idea. Maybe there are more rules worth implementing?

[janedbal]

There might be some, but the package is aiming to more strict codebases than this one is, so many of them could not be enabled. Also, it is tested only on PHP 7.4+. So probably not worth the effort.

[PhilETaylor]

this created this b/c break in a minor release :( #10621