Added doc for the fields parameter of the UniqueConstraint attribute #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stollr
force-pushed
the
doc_attr_uniqueconstraint
branch
from
64d93b7 to
77822d6
Compare
SenseException
approved these changes
May 3, 2023
|
It doesn't seem to be in use in the ORM code/tests. |
greg0ire
reviewed
May 4, 2023
| @@ -1104,7 +1104,8 @@ context. | |||
| Required parameters: | |||
|
|
|||
| - **name**: Name of the Index | |||
| - **columns**: Array of columns. | |||
| - **fields**: Array of fields (the names of the properties, used in the entity class). | |||
There was a problem hiding this comment.
If it's not used in tests, how can it be a required parameter?
There was a problem hiding this comment.
💡 nevermind, it's required to provide either columns or fields.
|
This was introduced in #8629. This is, in fact, covered by tests. |
|
Thanks @stollr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description for the fields parameter of the
UniqueConstraintattribute is missing at the moment (see here).