Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call canEmulateSchemas in SchemaTool when possible #10762

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

nicolas-grekas
Copy link
Member

No description provided.

@nicolas-grekas nicolas-grekas force-pushed the deprec-schematools branch 2 times, most recently from 7bd66f7 to 5e27d86 Compare June 5, 2023 13:49
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense not calling canEmulateSchemas if all assets are in the default schema, because in that case there are no assets to remove.

@derrabus derrabus added the Bug label Jun 5, 2023
@derrabus derrabus added this to the 2.15.3 milestone Jun 5, 2023
@derrabus derrabus merged commit 6c9b29f into doctrine:2.15.x Jun 5, 2023
@nicolas-grekas nicolas-grekas deleted the deprec-schematools branch June 5, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants